Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: auto update gist in CocoaPods #303

Merged
merged 1 commit into from Apr 27, 2023
Merged

Conversation

Shahroz16
Copy link
Contributor

3.0.0 up to (but not including) 4.0.0

Complete each step to get your pull request merged in. Learn more about the workflow this project uses.

  • Assign members of your team to review the pull request.
  • Wait for pull request status checks to complete. If there are problems, fix them until you see that all status checks are passing.
  • Wait until the pull request has been reviewed and approved by a teammate
  • After code reviews are approved and you determine this PR is ready to merge, select Squash and Merge button on this screen, leave the title and description to the default values, then merge the PR.

3.0.0 up to (but not including) 4.0.0
@Shahroz16 Shahroz16 requested a review from a team April 27, 2023 15:12
@github-actions
Copy link

github-actions bot commented Apr 27, 2023

Pull request title looks good 👍!

If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.0.1. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...

This project uses a special format for pull requests titles. Don't worry, it's easy!

This pull request title should be in this format:

<type>: short description of change being made

If your pull request introduces breaking changes to the code, use this format:

<type>!: short description of breaking change

where <type> is one of the following:

  • feat: - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project.

  • fix: - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project.

  • docs: - This pull request is making documentation changes, only.

  • refactor: - A change was made that doesn't fix a bug or add a feature.

  • test: - Adds missing tests or fixes broken tests.

  • style: - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc)

  • perf: - Changes improve performance of the code.

  • build: - Changes to the build system (maven, npm, gulp, etc)

  • ci: - Changes to the CI build system (Travis, GitHub Actions, Circle, etc)

  • chore: - Other changes to project that don't modify source code or test files.

  • revert: - Reverts a previous commit that was made.

Examples:

feat: edit profile photo
refactor!: remove deprecated v1 endpoints
build: update npm dependencies
style: run formatter 

Need more examples? Want to learn more about this format? Check out the official docs.

Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.

@levibostian
Copy link
Member

levibostian commented Apr 27, 2023

I am checking if we need to update SPM manifest file to do the same.

Update: We are already using the from: syntax which updates automatically to the next major version.

No update needed on this PR to satisfy SPM.

@levibostian levibostian changed the title fix: auto updated gist dependency fix: auto update gist in CocoaPods Apr 27, 2023
@levibostian
Copy link
Member

levibostian commented Apr 27, 2023

Modified title based on my comment that this change will only be for cocoapods, SPM change not done in this PR.

Thanks for making this change!

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #303 (b25895b) into main (ecbb768) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #303   +/-   ##
=======================================
  Coverage   56.24%   56.24%           
=======================================
  Files         105      105           
  Lines        1177     1177           
=======================================
  Hits          662      662           
  Misses        515      515           

@Shahroz16 Shahroz16 merged commit 6096d17 into main Apr 27, 2023
15 of 18 checks passed
@Shahroz16 Shahroz16 deleted the shahroz/auto-update-gist-pods branch April 27, 2023 15:47
github-actions bot pushed a commit that referenced this pull request Apr 27, 2023
### [2.4.1](2.4.0...2.4.1) (2023-04-27)

### Bug Fixes

* auto update gist in CocoaPods ([#303](#303)) ([6096d17](6096d17))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants