Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: in-app dismiss message #320

Merged
merged 7 commits into from May 26, 2023
Merged

feat: in-app dismiss message #320

merged 7 commits into from May 26, 2023

Conversation

ami-aman
Copy link
Contributor

@ami-aman ami-aman commented May 18, 2023

closes https://github.com/customerio/issues/issues/9930

PR for in-app dismiss message. Import CioMessagingInApp and call the method MessagingInApp.shared.dismissMessage() to dismiss active in-app message shown on the screen.


Complete each step to get your pull request merged in. Learn more about the workflow this project uses.

  • Assign members of your team to review the pull request.
  • Wait for pull request status checks to complete. If there are problems, fix them until you see that all status checks are passing.
  • Wait until the pull request has been reviewed and approved by a teammate
  • After code reviews are approved and you determine this PR is ready to merge, select Squash and Merge button on this screen, leave the title and description to the default values, then merge the PR.

@github-actions
Copy link

github-actions bot commented May 18, 2023

Pull request title looks good 👍!

If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.1.0. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...

This project uses a special format for pull requests titles. Don't worry, it's easy!

This pull request title should be in this format:

<type>: short description of change being made

If your pull request introduces breaking changes to the code, use this format:

<type>!: short description of breaking change

where <type> is one of the following:

  • feat: - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project.

  • fix: - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project.

  • docs: - This pull request is making documentation changes, only.

  • refactor: - A change was made that doesn't fix a bug or add a feature.

  • test: - Adds missing tests or fixes broken tests.

  • style: - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc)

  • perf: - Changes improve performance of the code.

  • build: - Changes to the build system (maven, npm, gulp, etc)

  • ci: - Changes to the CI build system (Travis, GitHub Actions, Circle, etc)

  • chore: - Other changes to project that don't modify source code or test files.

  • revert: - Reverts a previous commit that was made.

Examples:

feat: edit profile photo
refactor!: remove deprecated v1 endpoints
build: update npm dependencies
style: run formatter 

Need more examples? Want to learn more about this format? Check out the official docs.

Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.

@github-actions
Copy link

github-actions bot commented May 18, 2023

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • CocoaPods-FCM: aman/in-app-dismiss-message (1684751194)
  • APN-UIKit: aman/in-app-dismiss-message (1684751232)

@ami-aman ami-aman marked this pull request as ready for review May 22, 2023 10:22
@ami-aman ami-aman requested a review from a team May 22, 2023 10:27
Copy link
Member

@levibostian levibostian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the PR implementation doesn't align with the design of the feature, I will request changes for now.

Sources/MessagingInApp/MessagingInApp.swift Show resolved Hide resolved
Sources/MessagingInApp/MessagingInApp.swift Show resolved Hide resolved
@matt-frizzell matt-frizzell requested a review from a team May 23, 2023 16:11
@ami-aman ami-aman merged commit e067001 into main May 26, 2023
10 checks passed
@ami-aman ami-aman deleted the aman/in-app-dismiss-message branch May 26, 2023 12:44
github-actions bot pushed a commit that referenced this pull request May 26, 2023
## [2.6.0](2.5.3...2.6.0) (2023-05-26)

### Features

* in-app dismiss message ([#320](#320)) ([e067001](e067001))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants