Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong thread when invoking webview #351

Merged
merged 5 commits into from Jul 12, 2023
Merged

fix: wrong thread when invoking webview #351

merged 5 commits into from Jul 12, 2023

Conversation

Shahroz16
Copy link
Contributor

@Shahroz16 Shahroz16 commented Jul 12, 2023 •
edited

@github-actions
Copy link

github-actions bot commented Jul 12, 2023 •
edited

Pull request title looks good 👍!

If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.0.1. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...

This project uses a special format for pull requests titles. Don't worry, it's easy!

This pull request title should be in this format:

<type>: short description of change being made

If your pull request introduces breaking changes to the code, use this format:

<type>!: short description of breaking change

where <type> is one of the following:

  • feat: - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project.

  • fix: - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project.

  • docs: - This pull request is making documentation changes, only.

  • refactor: - A change was made that doesn't fix a bug or add a feature.

  • test: - Adds missing tests or fixes broken tests.

  • style: - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc)

  • perf: - Changes improve performance of the code.

  • build: - Changes to the build system (maven, npm, gulp, etc)

  • ci: - Changes to the CI build system (Travis, GitHub Actions, Circle, etc)

  • chore: - Other changes to project that don't modify source code or test files.

  • revert: - Reverts a previous commit that was made.

Examples:

feat: edit profile photo
refactor!: remove deprecated v1 endpoints
build: update npm dependencies
style: run formatter

Need more examples? Want to learn more about this format? Check out the official docs.

Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.

@github-actions
Copy link

github-actions bot commented Jul 12, 2023 •
edited

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.

  • APN-UIKit: shahroz/fix-in-app-main-thread-crash (1689170283)
  • CocoaPods-FCM: shahroz/fix-in-app-main-thread-crash (1689170501)

@Shahroz16 Shahroz16 self-assigned this Jul 12, 2023
@Shahroz16 Shahroz16 requested a review from a team July 12, 2023 12:38
ami-aman
ami-aman reviewed Jul 12, 2023
View reviewed changes
Sources/MessagingInApp/MessagingInAppImplementation.swift Outdated
@@ -68,7 +70,10 @@ extension MessagingInAppImplementation: ScreenTrackingHook {
public func screenViewed(name: String) {
logger.debug("setting route for in-app to \(name)")

inAppProvider.setRoute(name)
// Gist expects webview to be launched in UI thread and chaging route will trigger locally stored in-app messages for that route
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Gist expects webview to be launched in UI thread and chaging route will trigger locally stored in-app messages for that route
// Gist expects webview to be launched in main thread and changing route will trigger locally stored in-app messages for that route.

ami-aman
ami-aman approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@ami-aman ami-aman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good to me. Please review the only suggestion I added!

@Shahroz16 Shahroz16 merged commit 83495e8 into shahroz/gist-migration Jul 12, 2023
9 checks passed
@Shahroz16 Shahroz16 deleted the shahroz/fix-in-app-main-thread-crash branch July 12, 2023 13:56
Shahroz16 added a commit that referenced this pull request Jul 12, 2023
@Shahroz16
fix: gist migration to CIO (#338) (#351)
5520a7c
github-actions bot pushed a commit that referenced this pull request Jul 12, 2023
@semantic-release-bot
chore: prepare for 2.7.2
6e53c1b 
## [2.7.2](2.7.1...2.7.2) (2023-07-12)

### Bug Fixes

* gist migration to CIO ([#338](#338)) ([#351](#351)) ([5520a7c](5520a7c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ami-aman ami-aman ami-aman approved these changes

Assignees

@Shahroz16 Shahroz16

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Shahroz16 @ami-aman