Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: in-app positioning and persistence #393

Merged
merged 1 commit into from Oct 18, 2023

Conversation

Shahroz16
Copy link
Contributor

More details on it can be found on Slack.

@github-actions
Copy link

github-actions bot commented Oct 18, 2023

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • CocoaPods-FCM: shahroz/fix-message-persistance-and-positioning (1697621767)
  • APN-UIKit: shahroz/fix-message-persistance-and-positioning (1697621724)

@BernardGatt
Copy link
Contributor

LGTM

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #393 (8efb7b4) into main (b0f309f) will decrease coverage by 0.61%.
Report is 2 commits behind head on main.
The diff coverage is 54.54%.

@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
- Coverage   60.07%   59.47%   -0.61%     
==========================================
  Files         119      119              
  Lines        4556     4602      +46     
==========================================
  Hits         2737     2737              
- Misses       1819     1865      +46     
Files Coverage Δ
Sources/Common/Background Queue/QueueRunner.swift 69.07% <100.00%> (+2.40%) ⬆️
Sources/Common/Extensions/ResultExtensions.swift 100.00% <100.00%> (ø)
...agingInApp/Gist/Managers/MessageQueueManager.swift 29.21% <0.00%> (-0.68%) ⬇️
.../MessagingInApp/Gist/Managers/Models/Message.swift 79.71% <89.65%> (+2.15%) ⬆️
.../MessagingInApp/Gist/Managers/MessageManager.swift 12.96% <0.00%> (-4.27%) ⬇️
Sources/MessagingInApp/Gist/Gist.swift 23.52% <0.00%> (-9.11%) ⬇️

... and 2 files with indirect coverage changes

@Shahroz16 Shahroz16 merged commit b5a2f18 into main Oct 18, 2023
10 checks passed
@Shahroz16 Shahroz16 deleted the shahroz/fix-message-persistance-and-positioning branch October 18, 2023 10:24
github-actions bot pushed a commit that referenced this pull request Oct 18, 2023
## [2.8.4](2.8.3...2.8.4) (2023-10-18)

### Bug Fixes

* in-app positioning and persistence ([#393](#393)) ([b5a2f18](b5a2f18))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants