fix: when queue cannot find task, expect queue runs next task #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
Codecov Report
@@ Coverage Diff @@
## main #397 +/- ##
==========================================
+ Coverage 56.11% 59.16% +3.05%
==========================================
Files 103 119 +16
Lines 1153 4602 +3449
==========================================
+ Hits 647 2723 +2076
- Misses 506 1879 +1373
|
ami-aman
reviewed
Oct 27, 2023
| @@ -95,7 +95,7 @@ public class CioQueueRunRequest: QueueRunRequest { | |||
|
|
|||
| // The task failed to execute like a HTTP failure. Update `lastFailedTask`. | |||
| updateWhileLoopLogicVariables(didTaskFail: true, taskJustExecuted: nextTaskToRunInventoryItem) | |||
| break | |||
| continue // quit loop early and move to next task. | |||
There was a problem hiding this comment.
Does this possibly fix the bug that the customer reported ?
ami-aman
approved these changes
Oct 27, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Oct 27, 2023
## [2.8.5](2.8.4...2.8.5) (2023-10-27) ### Bug Fixes * when queue cannot find task, expect queue runs next task ([#397](#397)) ([01ea7a6](01ea7a6))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Through reviewing a set of SDK debug logs recently, I noticed the queue can get into an edge case that prevents it from ever finishing. Blocking the queue from running any more tasks while the app is in memory.
I was able to reproduce the issue through a test and then implemented a bug fix.