Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get currently registered device token #398

Merged
merged 5 commits into from Oct 31, 2023
Merged

Conversation

ami-aman
Copy link
Contributor

@ami-aman ami-aman commented Oct 27, 2023

To fetch the already stored device token from the SDK.
This feature will require the customer to write the code (as they do today) in AppDelegate to register the device when the token is generated. This feature does not auto save the token.

This PR is an attempt to elevate https://github.com/customerio/issues/issues/11181.

Steps to test the feature - same for APN and FCM apps

  • Launch iOS app
  • Login into the app
  • Tap on settings button on the top-right corner
  • Check if device token shown in device token field
  • Launch iOS app
  • Tap on settings button on the top-right corner
  • Check if device token shown in device token field

Complete each step to get your pull request merged in. Learn more about the workflow this project uses.

  • Assign members of your team to review the pull request.
  • Wait for pull request status checks to complete. If there are problems, fix them until you see that all status checks are passing.
  • Wait until the pull request has been reviewed and approved by a teammate
  • After code reviews are approved and you determine this PR is ready to merge, select Squash and Merge button on this screen, leave the title and description to the default values, then merge the PR.

@ami-aman ami-aman requested a review from a team October 27, 2023 18:32
@github-actions
Copy link

github-actions bot commented Oct 27, 2023

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • APN-UIKit: aman/fetch-token-11181 (1698738574)
  • CocoaPods-FCM: aman/fetch-token-11181 (1698738621)

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #398 (4848253) into main (01ea7a6) will increase coverage by 0.48%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #398      +/-   ##
==========================================
+ Coverage   59.16%   59.65%   +0.48%     
==========================================
  Files         119      119              
  Lines        4602     4608       +6     
==========================================
+ Hits         2723     2749      +26     
+ Misses       1879     1859      -20     
Files Coverage Δ
Sources/Tracking/CustomerIO.swift 87.50% <100.00%> (+0.28%) ⬆️
Sources/Tracking/CustomerIOImplementation.swift 91.52% <100.00%> (+0.08%) ⬆️

... and 3 files with indirect coverage changes

@levibostian levibostian changed the title feat: fetch stored device token from sdk without swizzling feat: get currently registered device token Oct 27, 2023
@levibostian
Copy link
Member

Updated title to a title I think is more descriptive to what the PR adds.

Anyone, feel free to edit if you think of something better.

@ami-aman ami-aman merged commit cdedab0 into main Oct 31, 2023
10 checks passed
@ami-aman ami-aman deleted the aman/fetch-token-11181 branch October 31, 2023 09:33
github-actions bot pushed a commit that referenced this pull request Oct 31, 2023
## [2.9.0](2.8.5...2.9.0) (2023-10-31)

### Features

* get currently registered device token ([#398](#398)) ([cdedab0](cdedab0))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants