Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rich push image downloading path conflict when its already downloaded #561

Merged
merged 1 commit into from Feb 23, 2024

Conversation

Shahroz16
Copy link
Contributor

more context: https://www.loom.com/share/971cb87f0216460faa0cefbf4fc9591e

and similar merged PR for cdp, where this issue was found : #551

@Shahroz16 Shahroz16 requested a review from a team February 23, 2024 11:03
Copy link

github-actions bot commented Feb 23, 2024

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • CocoaPods-FCM: shahroz/fix-nse-image-edge-case (1708686308)
  • APN-UIKit: shahroz/fix-nse-image-edge-case (1708686273)

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.79%. Comparing base (251a958) to head (8c6b48a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #561      +/-   ##
==========================================
+ Coverage   56.25%   56.79%   +0.53%     
==========================================
  Files         132      132              
  Lines        3715     3717       +2     
==========================================
+ Hits         2090     2111      +21     
+ Misses       1625     1606      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shahroz16 Shahroz16 merged commit 67cbfd6 into main Feb 23, 2024
10 checks passed
@Shahroz16 Shahroz16 deleted the shahroz/fix-nse-image-edge-case branch February 23, 2024 11:32
github-actions bot pushed a commit that referenced this pull request Feb 23, 2024
## [2.12.2](2.12.1...2.12.2) (2024-02-23)

### Bug Fixes

* rich push image downloading path conflict when its already downloaded ([#561](#561)) ([67cbfd6](67cbfd6))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants