fix: update segment internal SPM dependencies with fixed version #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
SDK binary size reports 📊SDK binary size of this PRSDK binary size diff report between this PR and the main branch |
mrehan27
approved these changes
Apr 22, 2024
Package.swift
Outdated
| @@ -45,7 +45,7 @@ let package = Package( | |||
| .package(name: "Firebase", url: "https://github.com/firebase/firebase-ios-sdk.git", "8.7.0"..<"11.0.0"), | |||
|
|
|||
| // The version is a git commit hash. Make sure the commit is the same as what the DataPipelines CocoaPods is using. | |||
There was a problem hiding this comment.
I just noticed this comment needs to be updated 😅
Package.swift
Outdated
| @@ -45,7 +45,7 @@ let package = Package( | |||
| .package(name: "Firebase", url: "https://github.com/firebase/firebase-ios-sdk.git", "8.7.0"..<"11.0.0"), | |||
|
|
|||
| // The version is a git commit hash. Make sure the commit is the same as what the DataPipelines CocoaPods is using. | |||
| .package(name: "Segment", url: "https://github.com/customerio/cdp-analytics-swift.git", .exact("1.5.9+cio.1")) | |||
| .package(name: "Segment", url: "https://github.com/customerio/cdp-analytics-swift.git", .exact("1.5.9+cio.2")) | |||
There was a problem hiding this comment.
We don't need the same change for pods, correct?
There was a problem hiding this comment.
I think we do need to update the podspec files in this PR, too.
I say that because in version 1.5.9+cio.2 of our fork, the Package.swift file was modified to hard-code dependencies. But .podspec file in 1.5.9+cio.2 does not hard-code the dependencies versions.
I think what needs to happen is:
- Our iOS SDK uses a hard-coded version of our fork in Package.swift and .podspec files.
- Our fork uses hard-coded versions of dependencies in both Package.swift and .podspec
There was a problem hiding this comment.
Both of the versions that you pointed to are not dependent on Segment, they are also CIO forks (Segment don't support their cocoapods) so we are responsible for updating them, and hence even if they are not fixed its okay, they are not in hands of Segment.
There was a problem hiding this comment.
I update the forks and cocoapods releases to match the same versions, for clarity.
levibostian
requested changes
Apr 23, 2024
Package.swift
Outdated
| @@ -45,7 +45,7 @@ let package = Package( | |||
| .package(name: "Firebase", url: "https://github.com/firebase/firebase-ios-sdk.git", "8.7.0"..<"11.0.0"), | |||
|
|
|||
| // The version is a git commit hash. Make sure the commit is the same as what the DataPipelines CocoaPods is using. | |||
| .package(name: "Segment", url: "https://github.com/customerio/cdp-analytics-swift.git", .exact("1.5.9+cio.1")) | |||
| .package(name: "Segment", url: "https://github.com/customerio/cdp-analytics-swift.git", .exact("1.5.9+cio.2")) | |||
There was a problem hiding this comment.
I think we do need to update the podspec files in this PR, too.
I say that because in version 1.5.9+cio.2 of our fork, the Package.swift file was modified to hard-code dependencies. But .podspec file in 1.5.9+cio.2 does not hard-code the dependencies versions.
I think what needs to happen is:
- Our iOS SDK uses a hard-coded version of our fork in Package.swift and .podspec files.
- Our fork uses hard-coded versions of dependencies in both Package.swift and .podspec
Shahroz16
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #708 +/- ##
==========================================
- Coverage 56.93% 56.91% -0.03%
==========================================
Files 139 139
Lines 3869 3869
==========================================
- Hits 2203 2202 -1
- Misses 1666 1667 +1 ☔ View full report in Codecov by Sentry. |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 24, 2024
## [3.1.3](3.1.2...3.1.3) (2024-04-24) ### Bug Fixes * update segment internal SPM dependencies with fixed version ([#708](#708)) ([c02742e](c02742e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the new Segment release, the internal dependencies (sovran, JSON encoder) versions are fixed.