Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: autoupdate to latest major version of iOS SDK #124

Merged
merged 1 commit into from May 3, 2023

Conversation

levibostian
Copy link
Member

@levibostian levibostian commented Apr 24, 2023

This will need tested in Ami to confirm that our SDK is compatible with latest native iOS SDK.

QA builds being created over in the Ami RN github repo

QA

iOS Ami RN app build to QA test with: levi/auto-update-ios (1682348352)

QA steps:

This PR updates the native iOS SDK version that is used by the RN SDK. In order for this PR to pass QA, we need to run the smoke test suite to confirm the SDK functionality is stable. This PR does not add any new features or bug fixes to the RN SDK. We simply need to test existing SDK functionality to assert that there are not issues.

@github-actions
Copy link

github-actions bot commented Apr 24, 2023

Pull request title looks good 👍!

If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.0.1. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...

This project uses a special format for pull requests titles. Don't worry, it's easy!

This pull request title should be in this format:

<type>: short description of change being made

If your pull request introduces breaking changes to the code, use this format:

<type>!: short description of breaking change

where <type> is one of the following:

  • feat: - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project.

  • fix: - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project.

  • docs: - This pull request is making documentation changes, only.

  • refactor: - A change was made that doesn't fix a bug or add a feature.

  • test: - Adds missing tests or fixes broken tests.

  • style: - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc)

  • perf: - Changes improve performance of the code.

  • build: - Changes to the build system (maven, npm, gulp, etc)

  • ci: - Changes to the CI build system (Travis, GitHub Actions, Circle, etc)

  • chore: - Other changes to project that don't modify source code or test files.

  • revert: - Reverts a previous commit that was made.

Examples:

feat: edit profile photo
refactor!: remove deprecated v1 endpoints
build: update npm dependencies
style: run formatter 

Need more examples? Want to learn more about this format? Check out the official docs.

Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.

@levibostian levibostian requested a review from a team April 24, 2023 12:59
@levibostian levibostian self-assigned this Apr 24, 2023
@jasonto
Copy link

jasonto commented Apr 26, 2023

Not able to receive push notification with build levi/auto-update-ios (1682452762)

@ami-aman
Copy link
Collaborator

ami-aman commented May 3, 2023

Not able to receive push notification with build levi/auto-update-ios (1682452762)

Fixed this, @jasonto ! You should be able to receive push notifications now. Let me know if you still do not.

@Shahroz16
Copy link
Contributor

I am merging it to unblock customers. We have tested and it seems to work, Jason was able to make it work but was having issues with not getting push notifications on APN, which was down to configuration issue and not SDK.

@Shahroz16 Shahroz16 merged commit 7904c50 into main May 3, 2023
9 checks passed
@Shahroz16 Shahroz16 deleted the levi/auto-update-ios branch May 3, 2023 10:35
github-actions bot pushed a commit that referenced this pull request May 3, 2023
### [2.3.3](2.3.2...2.3.3) (2023-05-03)

### Bug Fixes

* autoupdate to latest major version of iOS SDK ([#124](#124)) ([7904c50](7904c50))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants