Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expo user agent #49

Merged
merged 30 commits into from Dec 1, 2022
Merged

feat: expo user agent #49

merged 30 commits into from Dec 1, 2022

Conversation

xtreem88
Copy link
Collaborator

@xtreem88 xtreem88 commented Nov 17, 2022

This resolves https://github.com/customerio/issues/issues/8574 on React Native SDK end

Approach

  • Created post-install script
  • After the package is installed, post-install script checks if customerio-expo-plugin is installed
  • If found, read customerio-expo-plugin/package.json and get version
  • set expoVersion in the current package's package.json file and save

@ami-oss-ci
Copy link

ami-oss-ci commented Nov 17, 2022

Pull request title looks good 👍!

If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.1.0. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

To merge this pull request, add the label Ready to merge to this pull request and I'll merge it for you.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...

This project uses a special format for pull requests titles. Don't worry, it's easy!

This pull request title should be in this format:

<type>: short description of change being made

If your pull request introduces breaking changes to the code, use this format:

<type>!: short description of breaking change

where <type> is one of the following:

  • feat: - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project.

  • fix: - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project.

  • docs: - This pull request is making documentation changes, only.

  • refactor: - A change was made that doesn't fix a bug or add a feature.

  • test: - Adds missing tests or fixes broken tests.

  • style: - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc)

  • perf: - Changes improve performance of the code.

  • build: - Changes to the build system (maven, npm, gulp, etc)

  • ci: - Changes to the CI build system (Travis, GitHub Actions, Circle, etc)

  • chore: - Other changes to project that don't modify source code or test files.

  • revert: - Reverts a previous commit that was made.

Examples:

feat: edit profile photo
refactor!: remove deprecated v1 endpoints
build: update npm dependencies
style: run formatter 

Need more examples? Want to learn more about this format? Check out the official docs.

Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.

@xtreem88 xtreem88 changed the title User agent fix feat!: Expo User agent Nov 17, 2022
@xtreem88 xtreem88 changed the title feat!: Expo User agent feat: Expo User agent Nov 17, 2022
@xtreem88 xtreem88 changed the title feat: Expo User agent feat: expo user agent Nov 17, 2022
src/postInstall.js Outdated Show resolved Hide resolved
src/postInstall.js Outdated Show resolved Hide resolved
src/postInstall.js Outdated Show resolved Hide resolved
refactor: modified post install script
Copy link
Member

@levibostian levibostian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I unresolved a prior conversation.

src/postInstall.js Outdated Show resolved Hide resolved
src/postInstall.js Show resolved Hide resolved
@xtreem88 xtreem88 merged commit 377300c into develop Dec 1, 2022
@xtreem88 xtreem88 deleted the user-agent-fix branch December 1, 2022 12:45
ami-ci pushed a commit that referenced this pull request Dec 19, 2022
## [2.0.0-alpha.1](1.0.1-alpha.3...2.0.0-alpha.1) (2022-12-19)

### ⚠ BREAKING CHANGES

* bumped ios version to 2.0.0

### Features

* expo user agent ([#49](#49)) ([377300c](377300c))

### Bug Fixes

* bumped ios version to 2.0.0 ([95f74b9](95f74b9))
@ami-ci
Copy link
Contributor

ami-ci commented Dec 19, 2022

🎉 This PR is included in version 2.0.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

ami-ci pushed a commit that referenced this pull request Dec 30, 2022
## [2.0.0-beta.1](1.0.0...2.0.0-beta.1) (2022-12-30)

### ⚠ BREAKING CHANGES

* bumped ios version to 2.0.0

### Features

* expo user agent ([#49](#49)) ([377300c](377300c))

### Bug Fixes

* added support for android sdk 3.2.0 ([c0407be](c0407be))
* bumped ios version to 2.0.0 ([95f74b9](95f74b9))
* for test case failure due to file path ([ce43198](ce43198))
* ios and android sdk version update ([28e9ad3](28e9ad3))
* ios sdk latest version ([66c4607](66c4607))
* support for expo client ([b641fd8](b641fd8))
* updated ios sdk to 1.2.2 ([6605d56](6605d56))
* updating to latest iOS SDK version ([a9c90f0](a9c90f0))
@ami-ci
Copy link
Contributor

ami-ci commented Dec 30, 2022

🎉 This PR is included in version 2.0.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

ami-ci pushed a commit that referenced this pull request Jan 18, 2023
## [2.0.0](1.0.0...2.0.0) (2023-01-18)

### ⚠ BREAKING CHANGES

* bumped ios version to 2.0.0

### Features

* expo user agent ([#49](#49)) ([377300c](377300c))

### Bug Fixes

* added support for android sdk 3.2.0 ([c0407be](c0407be))
* bumped ios version to 2.0.0 ([95f74b9](95f74b9))
* for test case failure due to file path ([ce43198](ce43198))
* ios and android sdk version update ([28e9ad3](28e9ad3))
* ios sdk latest version ([66c4607](66c4607))
* support for expo client ([b641fd8](b641fd8))
* updated ios sdk to 1.2.2 ([6605d56](6605d56))
* updating to latest iOS SDK version ([a9c90f0](a9c90f0))
@ami-ci
Copy link
Contributor

ami-ci commented Jan 18, 2023

🎉 This PR is included in version 2.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants