Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove trailing commas at the end of hash #29

Closed
wants to merge 1 commit into from
Closed

remove trailing commas at the end of hash #29

wants to merge 1 commit into from

Conversation

chr4
Copy link

@chr4 chr4 commented Aug 20, 2013

this restores compatibility with ruby 1.8

this restores compatibility with ruby 1.8
@sethvargo
Copy link
Contributor

@chr4 thank you for the PR. This cookbook requires Ruby 1.9 or higher, as documented in the README. If you want 1.8 support, you'll need to use a version in the 1.0.x series. Opscode's omnibus installer uses Ruby 1.9.3, and Ruby 1.8 has been officially deprecated.

@sethvargo sethvargo closed this Aug 20, 2013
@chr4
Copy link
Author

chr4 commented Aug 20, 2013

srsly? Two commas for the cost of breaking compatibility?
Please don't make me maintain a fork for the sake of 2 bytes...

@sethvargo
Copy link
Contributor

@chr4 there are additional incompatibilities that arise in the File class and other places as well. You can use an older version of the cookbook that has 1.8.7 compatibility - I follow semver in this cookbook. Those trailing commas are encouraged by multiple git/ruby style guides, as it improves the readability of git diffs. You don't need to maintain a fork - either use Opscode's omnibus installer (which has a compatible version of Ruby) or use the 1.0.x series of the cookbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants