Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing extra commas on Manipulator class #33

Closed
wants to merge 1 commit into from
Closed

Removing extra commas on Manipulator class #33

wants to merge 1 commit into from

Conversation

Draiken
Copy link

@Draiken Draiken commented Sep 10, 2013

This is breaking everything using hostsfile's 2.0 version.

@Draiken
Copy link
Author

Draiken commented Sep 10, 2013

If possible, please bump the version so I can download from opscode again :)

@sethvargo
Copy link
Contributor

#29

@sethvargo sethvargo closed this Sep 10, 2013
@sethvargo
Copy link
Contributor

@Draiken
Copy link
Author

Draiken commented Sep 12, 2013

I'm sorry about the confusion, I wasn't trying to bring support back to 1.8, someone on our company updated the recipe without looking at the version breaking changes and when the error happened I assumed it was just the extra commas (a feature I didn't really know about 1.9).

Thanks for this great cookbook and sorry for the inconvenience.

@sethvargo
Copy link
Contributor

No problem! I am just frustrated because I follow semantic versioning and clearly documented this breaking change and there were 5+ PRs fixing the issue :(

This message was sent from my mobile device.

I apologize in advance for any typographical errors or autocorrections.

On Sep 12, 2013, at 6:57 AM, "Luiz Felipe G. Pereira" notifications@github.com wrote:

I'm sorry about the confusion, I wasn't trying to bring support back to 1.8, someone on our company updated the recipe without looking at the version breaking changes and when the error happened I assumed it was just the extra commas (a feature I didn't really know about 1.9).

Thanks for this great cookbook and sorry for the inconvenience.


Reply to this email directly or view it on GitHub.

@Draiken
Copy link
Author

Draiken commented Sep 12, 2013

I think unfortunately because of the nature of the error that shows on ruby 1.8 (invalid syntax) people think it's a simple change and end up making the pull request on a rush.

Maybe throw a specific exception when 1.8.7 is used? I guess it's not possible because the error happens when the cookbook is uploaded... I don't know how I'd deal with it.

@sethvargo
Copy link
Contributor

@Draiken I'm going to release the next version with Ruby 1.9-specific hashes. There's no directive in Chef to require a specific Ruby version, unfortunately. I've added boldness to the section of the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants