Use GitHub Container as Extension Installation. #17
Conversation
| @@ -24,7 +24,7 @@ jobs: | |||
| - name: Build & Run Development Container | |||
| uses: devcontainers/ci@v0.2 | |||
| with: | |||
| imageName: ghcr.io/customink/crypteia | |||
| imageName: ghcr.io/customink/crypteia-devcontainer | |||
There was a problem hiding this comment.
Not part of the PR here but I wanted to have each package (two container images soon) associated with this repo have intention revealing names.
| CRYPTEIA_VERSION: ${{ steps.changelog_reader.outputs.version }} | ||
| run: | | ||
| echo "${{ secrets.PUBLIC_GITHUB_TOKEN_PACKAGES }}" | docker login ghcr.io -u ${{ github.actor }} --password-stdin | ||
| ./layer/deploy-image |
There was a problem hiding this comment.
Using the new PUBLIC_GITHUB_TOKEN_PACKAGES secret (cc @shellerci) for our open source repos. This will push the Amazon Linux 2 container image along with the other release binary and shared object files. Hmm... typing this out, I think I should add -amzn suffix here too and make a debian one.
| @@ -0,0 +1,8 @@ | |||
| FROM alpine | |||
| LABEL org.opencontainers.image.source "https://github.com/customink/crypteia" | |||
There was a problem hiding this comment.
This is pretty neat... GitHub should use this label to associate the package with this repo.
| @@ -46,3 +46,9 @@ jobs: | |||
| prerelease: ${{ steps.changelog_reader.outputs.status == 'prereleased' }} | |||
| draft: ${{ steps.changelog_reader.outputs.status == 'unreleased' }} | |||
| token: ${{ secrets.GITHUB_TOKEN }} | |||
| - name: Push Lambda Extension Layer Image | |||
| env: | |||
| CRYPTEIA_VERSION: ${{ steps.changelog_reader.outputs.version }} | |||
There was a problem hiding this comment.
OMG, I'm so in love with this Action that parses the CHANGELOG.
The purpose of this pull request is to provide a simple interface to install the Lambda Extension for Lambda Containers. This post here (https://aws.amazon.com/blogs/compute/working-with-lambda-layers-and-extensions-in-container-images/) does a great job outlining the technique. The learnings here will influence an another open-source project to use Libvips with Ruby here (https://github.com/customink/ruby-vips-lambda).
@brcarp I will be making some ℹ️ comments on various parts of this and merging right away. Feel free to ask questions tho and see what eventually lands in main after the merge.
Post Merge TODO