Ensure failed messages go to DLQ #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, setting no retries
…ion count hits max receive count so that messages can be sent to the DLQ
metaskills
reviewed
Nov 12, 2022
| @@ -52,7 +52,6 @@ class JobTest < LambdakiqSpec | |||
| expect(perform_buffer_last_value).must_equal 'ErrorJob with: "test"' | |||
| expect(logger).must_include 'Performing TestHelper::Jobs::ErrorJob' | |||
| expect(logger).must_include 'Error performing TestHelper::Jobs::ErrorJob' | |||
| # binding.pry ; return | |||
There was a problem hiding this comment.
Thanks for cleaning this up BTW.
There was a problem hiding this comment.
no worries, glad to help
|
Thank you so much! Released v2.1.0. Amazing work. I really appreciate it. |
|
No worries, glad I could help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When SQS is configured with a redrive policy into a dead letter queue, jobs that have not been processed correctly should end up in the DLQ after reaching the configured max receive count.
Changes
Messages will no longer be deleted from the queue after failing for the max receive count configured in the queue, and therefore SQS will handle sending messages to the DLQ.
If the main lambdakiq retry config, or a specific job retry config is less than the queue retry number, then the messages will still be deleted, otherwise SQS would continue to execute lambda until the queue max receive is reached and the configuration of retries would not be honored.