Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add includes to Jar file #3

Open
AL1L opened this issue Jan 26, 2022 · 3 comments
Open

Add includes to Jar file #3

AL1L opened this issue Jan 26, 2022 · 3 comments

Comments

@AL1L
Copy link

AL1L commented Jan 26, 2022

I have a request to add something to @customrealms/cli so this feature would work purfectly. Add something like configs argument.

{
  "name": "example-plugin",
   "version": "1.0.0",
   "description":  "",
   "configs": { 
       "config": "./configs/config.yml", 
       "messages": "./configs/messages.yml", 
       "data": "./configs/data.yml" 
  }
}

We need it so we could create configs and could add default creata form, it should be stored where plugin.yml is stored. Otherwise it will just not work!

Originally posted by @nedaras in customrealms/bukkit-runtime#9 (comment)

RE:
For your cli suggestion, I think it would be beneficial to do something like that for future options too, so we should do something like

{
  "name": "example-plugin",
  "version": "1.0.0",
  "description": "",
  "customrealms": {
    "includes": {
      "/": ["./configs/*.yml"]
    }
  }
}

The nesting under "customrealms" is per the CommonJS standard and to not conflict with other packages or future features. And, it's just my initial thought, but having an includes property with a map of dirs relative to the root of the jar to include files into using globs. If that makes sense

Originally posted by @AL1L in customrealms/bukkit-runtime#9 (comment)

@andriemc
Copy link

I would really like to see this be added.

@Pedromdsn
Copy link

Up

@connerdouglass
Copy link
Member

This makes sense, and we will add it. We need to refine the design of this, as well as customrealms/bukkit-runtime#9 (comment), but in general I think embedding resource files needs to be part of the CustomRealms development pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants