Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: realign the count of cards in the deck so it doesn’t touch the edge of the deck #231

Closed
itsalaidbacklife opened this issue Nov 25, 2022 · 6 comments · Fixed by #248
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@itsalaidbacklife
Copy link
Contributor

Feature Summary

The deck has a text blurb with the count of how many cards are in it, but it is awkwardly placed all the way at the bottom so it’s flush with the bottom of the deck. We should move it slightly upwards so there is a margin between the text and the bottom edge of the dexk

Detailed Description

The (1) in the picture should be moved slightly upwards.

@itsalaidbacklife itsalaidbacklife added enhancement New feature or request good first issue Good for newcomers labels Nov 25, 2022
@itsalaidbacklife
Copy link
Contributor Author

Uploading 4FCB761E-A988-4823-A413-105CD8671242.png…

@gulyapulya
Copy link
Contributor

Hi @itsalaidbacklife, I would like to work on this. However, I cannot view the picture you provided. Could you also navigate me to the file where the CSS is defined for this?

@itsalaidbacklife
Copy link
Contributor Author

@gulyapulya Thank you!
I'll re-upload the image for reference:
image

This style is controlled in client/js/views/GameView.vue.

You can look at the <v-card> html on lines 133-167 for where the deck is defined, and styles are at the bottom of that file

@gulyapulya
Copy link
Contributor

Hi, thanks a lot, I think adding margins to the c-deck-count should do the job, as it is the class controlling the count number. I am trying to make it work locally to test the change. I have the site working at localhost but I am not sure how to initiate the game as I cannot sign up twice - it just changes my username, could you help me with the steps to reproduce it?

@itsalaidbacklife
Copy link
Contributor Author

Agreed that a margin should do it.

To view it in the browser, you'll need to have two separate browser windows that don't share cookies. You can do that by having one window incognito and the other window not-incognito, or by using two different browsers e.g. chrome + firefox.

@gulyapulya
Copy link
Contributor

Thanks, @itsalaidbacklife! I have submitted a pull request 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants