-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DevEx #811 Postgres migration to timestamptz #824
base: main
Are you sure you want to change the base?
Conversation
This still needs a bunch of testing and a database migration, but I got a good start on the backend changes. |
The DB migration will probably look like this. Imo it makes sense to create the new columns and check a bunch of them before deleting and renaming. |
apparently you can't use one
The SQL is the same for the |
I tested this by staging the database on This should probably be tested by at least one other person. |
api/controllers/StatsController.js
Outdated
startTime: { '>': dayjs(currentSeason.startTime).format('YYYY-MM-DD HH:mm:ss.SSS Z') }, | ||
endTime: { '<': dayjs(currentSeason.endTime).format('YYYY-MM-DD HH:mm:ss.SSS Z') }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This string is used all over the place. Let's pull it into a utility file so that it can be imported and standardized. Since it's used in test code and backend, maybe it makes the most sense to make it json?
Something like utils/time.json
with
{
"formatString": "YYYY-MM-DD HH:mm:ss.SSS Z"
}
* test(videoPlayground): initialize queen video test * test(videoPlayground): add queen test * test(playground.config): update playground config to include all specs in and out of playground dir * test(videoPlayground): add test for queen video * test(videoPlayground): add spec for playing 2 to scrap royal * test(videoPlayground): add spec for countering * test(videoPlayground): add spec for threes * test(videoPlayground): add spec for fours * test(videoPlayground): add fives spec * test(videoPlayground): add specs for eight and nine * chore(videoPlayground): remove .only()
Issue number
Relevant issue number
timestampz
data type #811Please check the following
Please describe additional details for testing this change