Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Update all the RulePreview gifs in the RulesView to match the current GameView UI #908

Closed
itsalaidbacklife opened this issue May 13, 2024 · 0 comments · Fixed by #925
Labels
cyconf candidate Consider this for live coding demo showcasing cypress TDD enhancement New feature or request frontend Requires changes to the frontend (vue) client

Comments

@itsalaidbacklife
Copy link
Contributor

Feature Summary

The RulesView has .gifs of every move, but they are all of an older version of the app. We should update these to reflect the current look and feel.

Detailed Description

Here is an example .gif displayed on the RulesView:

https://github.com/cuttle-cards/cuttle-assets/blob/main/assets/ace.gif?raw=true

in contrast, the GameView now has a new design with a different deck of cards. We should recreate all the gifs and update the RuleView to showcase the moves in the context of the current UI.

To do this, we should add tests (one per move) to the playground specs in tests/e2e/playground/specs/videoPlayground.spec.js that automatically put the game into the necessary state and walk through the given move, using cy.wait() and cy.viewport() to control the timing and resolution of the showcase.

We should then create screen recordings of each test of each move, and convert those videos to .gifs (e.g. using Keynote), then commit the gifs into the Cuttle assets repo and then update all the urls of gifs in the RulesView data to point to the urls of the newly uploaded move gifs

@itsalaidbacklife itsalaidbacklife added enhancement New feature or request frontend Requires changes to the frontend (vue) client cyconf candidate Consider this for live coding demo showcasing cypress TDD labels May 13, 2024
@itsalaidbacklife itsalaidbacklife mentioned this issue May 21, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cyconf candidate Consider this for live coding demo showcasing cypress TDD enhancement New feature or request frontend Requires changes to the frontend (vue) client
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant