Security update #8103
Security update #8103
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis update to the Dockerfile focuses on upgrading the base image for Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- Dockerfile (2 hunks)
Additional comments not posted (3)
Dockerfile (3)
86-86: Approved: Updated golang base image versionThe base image version has been updated from
golang:1.22.3togolang:1.22.4to address security concerns. Ensure compatibility with the rest of the Dockerfile.
185-186: Approved: Uninstall pip from the virtual environmentPip is uninstalled from the virtual environment due to security reasons (CVE-2018-20225).
187-187: Approved: Remove python3-pip packageThe
python3-pippackage is removed due to security reasons (CVE-2018-20225).
Dockerfile
Outdated
| # Removing pip due to security reasons. See: https://scout.docker.com/vulnerabilities/id/CVE-2018-20225 | ||
| RUN /bin/bash -c "source /opt/venv/bin/activate && pip uninstall pip -y" |
There was a problem hiding this comment.
IMO, this vulnerability is pretty dubious (indeed, you can see that it's marked as disputed on the CVE website). Even if we consider it real, removing pip at this point does nothing for security, seeing as we don't actually use pip at runtime. Can we just ignore it?
There was a problem hiding this comment.
Yes, I agree with you, but some tools(like docker scout) marks it as a high vulnerability(even if we don't use pip at runtime) and I thought it would be better to remove it than to explain to customers that the vulnerability is dubious.
There was a problem hiding this comment.
Okay, I suppose that's fine. But then you ought add a more detailed explanation in the comment than just "security reasons".
Also, that command looks overcomplicated. Wouldn't it be sufficient to do python -m pip uninstall -y pip?
There was a problem hiding this comment.
Added more detailed comment.
Yea, python -m pip uninstall -y pip is work! Fixed it.
Dockerfile
Outdated
| @@ -182,6 +182,10 @@ RUN if [ "${CVAT_DEBUG_ENABLED}" = 'yes' ]; then \ | |||
| python3 -m pip install --no-cache-dir debugpy; \ | |||
| fi | |||
|
|
|||
| # Removing pip due to security reasons. See: https://scout.docker.com/vulnerabilities/id/CVE-2018-20225 | |||
| RUN /bin/bash -c "source /opt/venv/bin/activate && pip uninstall pip -y" | |||
| RUN apt-get remove -y python3-pip | |||
There was a problem hiding this comment.
I don't think this package is installed in this image in the first place.
There was a problem hiding this comment.
removed the unnecessary deletion
Dockerfile.ci
Outdated
| @@ -25,6 +25,7 @@ RUN apt-get update && \ | |||
| COPY cvat/requirements/ /tmp/cvat/requirements/ | |||
| COPY utils/dataset_manifest/requirements.txt /tmp/utils/dataset_manifest/requirements.txt | |||
|
|
|||
| RUN /opt/venv/bin/python3 -m ensurepip | |||
There was a problem hiding this comment.
| RUN /opt/venv/bin/python3 -m ensurepip | |
| RUN python3 -m ensurepip |
Motivation and context
Docker Scout found several vulnerabilities, updated or removed them
How has this been tested?
Checklist
developbranch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
golang:1.22.4for improved stability and performance.pipdue to security concerns related to CVE-2018-20225.