Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with newer flask-login #294

Closed
Malizor opened this issue Aug 28, 2018 · 4 comments
Closed

Fix compatibility with newer flask-login #294

Malizor opened this issue Aug 28, 2018 · 4 comments
Assignees

Comments

@Malizor
Copy link

Malizor commented Aug 28, 2018

In requirements.txt, we have the following: flask-login<=0.2.11.

As far as I know, this was supposed to be a temporary measure because of upstream problems with the 0.3.0 version (see #89). But now, the latest upstream version is 0.4.1.

cve-search should be patched so that the requirement can be bumped to follow upstream again.
I suggest to not require more than 0.4.0 for now, as this is the version available in Debian Stretch and Ubuntu 18.04.

@PidgeyL
Copy link
Member

PidgeyL commented Jul 17, 2019

Good point. Have you already tested if they are compatible or need code changes?

@Malizor
Copy link
Author

Malizor commented Jul 17, 2019

So it was last year, but as far as I remember it did not work out of the box.
I have no idea of the amount of work required.

@PidgeyL
Copy link
Member

PidgeyL commented Jul 19, 2019

I'll check it out

@PidgeyL PidgeyL self-assigned this Jul 19, 2019
@github-actions
Copy link

github-actions bot commented Oct 1, 2020

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants