New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial import restructure #451
Conversation
Maybe the best would have a complete set of CPE test search in travis and one with expected results? Just to be sure. Then we can merge it in the master/main branch and make a release. Your changes are really useful ;-) Thanks again. |
Rebased branch |
@adulau a complete set of tests would make sense, something like:
Or would you like search_fulltext to be tested separately as well? And the 2 tests (both for search.py and search_cpe.py) where to match the results to a expected outcome? With changing content that could be tricky; I'll look into it! |
Yep and comparing the result to a set of known good output would be just perfect. |
Codecov Report
@@ Coverage Diff @@
## master #451 +/- ##
==========================================
- Coverage 17.98% 17.47% -0.51%
==========================================
Files 37 46 +9
Lines 3604 3994 +390
==========================================
+ Hits 648 698 +50
- Misses 2956 3296 +340
Continue to review full report at Codecov.
|
I'm doing some final tests Today before the final merge ;-) |
Awesome! Quick question; are the entries from exploit-db available somewhere in cve_search? |
They were in VIA4CVE but not sure if they still provide the url with database. |
How would that reference be named in the via4 collection? |
FYI, https://cve-beta.circl.lu/ is now running this branch. |
In my test, there is a missing field which is |
Huh? That's strange; no definitely not intended. Where are you missing the last-modified field? Which collection, cves? The only collection I found that has that field is the info collection. |
I found the location where it was originally set; it's in the updateCVE method. I will correct it asap. |
Done |
A huge thanks @P-T-I for the hard work 🥇 We will update the official API one with this version and then we will do a release of cve-search in the next days. |
No problem; glad to help! I'll start working on the new cwe and capec releases. @adulau did you happen to take a look at the Travis settings? I believe parallel execution is disabled somehow? |
Took the liberty to redesign the (initial) import scripts and database populations. Structured logging and moved all print statements to the logging class. Initial import duration moved from several (4+) hours to less then an hour. Added update / populate progress monitoring via tqdm progress bars and (debug) logging. Fixed some typo's and wrong references.
Fixes #424
Fixes #435
Fixes #463