Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compatible with Laravel 5.2 #214

Closed
nivv opened this issue Dec 22, 2015 · 20 comments
Closed

Make compatible with Laravel 5.2 #214

nivv opened this issue Dec 22, 2015 · 20 comments

Comments

@nivv
Copy link

nivv commented Dec 22, 2015

According to the upgrade guide

The Illuminate\Foundation\Support\Composer class has been moved to Illuminate\Support\Composer. This is unlikely to affect your application if you were not manually using this class.

@Prashank25
Copy link

+1
I already upgraded to 5.2 and this broke. I can't wait so i will fork and fix this for now :/

@freekmurze
Copy link

+1

@nivv
Copy link
Author

nivv commented Dec 23, 2015

Pull request here: #215 by @EspadaV8

@unamix
Copy link

unamix commented Dec 23, 2015

+1

4 similar comments
@iainheng
Copy link

+1

@bernardomacedo
Copy link

+1

@mrcsmcln
Copy link

+1

@hiendv
Copy link

hiendv commented Dec 24, 2015

👍

@boynoiz
Copy link

boynoiz commented Dec 24, 2015

👍

@Malin88
Copy link

Malin88 commented Dec 28, 2015

+1

1 similar comment
@tommhuth
Copy link

+1

@freekmurze
Copy link

If your looking for a package to generate slugs in Laravel 5.2 take a look one at this one I coded up last week: https://github.com/spatie/laravel-sluggable

Colin's package is more feature rich, mine does only the basics. It also has PHP 7 as a minimum requirement.

@ljjakovljevic
Copy link

+1

3 similar comments
@jl4guna
Copy link

jl4guna commented Dec 30, 2015

+1

@luanrodrigues
Copy link

+1

@elimentz
Copy link

elimentz commented Jan 3, 2016

+1

@cviebrock
Copy link
Owner

Try the 3.1.4 release now, please. Rather than make a new branch just for L5.2 and maintaining both branches, etc., I've removed the calls to composer in the migration command. So, instead of doing:

php artisan sluggable:table posts

You need to do a few more things manually:

php artisan sluggable:table posts
composer dump-autoload
php artisan migrate

I think that was the only thing keeping this from working on 5.2, but would appreciate some "reports from the field".

@de-raaf-media
Copy link

Thanks!

@bernardomacedo
Copy link

So far id does work! :D 👍

@cviebrock
Copy link
Owner

Can you all also try the 4.0.0-beta release, which should work with L5.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests