Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined StorageClass #2

Closed
DzKerr opened this issue Aug 22, 2016 · 3 comments
Closed

Undefined StorageClass #2

DzKerr opened this issue Aug 22, 2016 · 3 comments

Comments

@DzKerr
Copy link

DzKerr commented Aug 22, 2016

Hi,

I have followed the installation instructions, but, I had an "Undefined StorageClass" error on the ServiceProvider.php file at line 91.
I think it is because the condition is

!is_null($app['config']['mangopay']['StorageClass'])

instead of

isset($app['config']['mangopay']['StorageClass']) && !is_null($app['config']['mangopay']['StorageClass'])

Now it is working in my app.
What do you think about it ?

@cviebrock
Copy link
Owner

I agree. This would be as a result of PR #1 from @brayniverse.

Can you make a PR to fix this? And I'd use array_get(), rather than the isset && ... construct.

Thanks!

@brayniverse
Copy link
Contributor

brayniverse commented Aug 23, 2016

Hey, sorry about that. I'll submit a PR as soon as I can. Unless somebody else does it first.

@cviebrock
Copy link
Owner

@DzKerr Let me know if this change fixes things for you (0.9.4 release)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants