Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user.external_url extended attribute (replaces #2924) #3101

Merged
merged 3 commits into from Nov 25, 2022

Conversation

HereThereBeDragons
Copy link
Contributor

@HereThereBeDragons HereThereBeDragons commented Nov 11, 2022

Extension of PR #2924

  • Added NULL check for external_downloadmgr
  • Extended integration test 615
  • Rebased it to match devel

Problems with test 615:

  • Extra check for has_correct_external_url works
    BUT following fails:

1 ) line 227

  create_stratum1 $CVMFS_TEST_615_REPLICA_NAME          \
                  $CVMFS_TEST_USER                       \
                  $CVMFS_STRATUM0                        \
                  /etc/cvmfs/keys/${CVMFS_TEST_REPO}.pub || return 110

with Installing GeoIP Database... CVMFS_GEO_LICENSE_KEY not set fail
2 ) rm ${repo_dir}/external/file || return 91 line 244 with
rm: cannot remove '/cvmfs/just.test.repo/external/file': Function not implemented

Commenting both sections out will make the test pass.

@jblomer jblomer changed the title user.external_url Xattr - Test + Change Request Add user.external_url extended attribute (replaces #2924) Nov 16, 2022
@jblomer
Copy link
Member

jblomer commented Nov 16, 2022

@HereThereBeDragons On your first point: we have a key that we use for testing. You can check our Jenkins managed nodes, in /etc/cvmfs/server.local. I can also give it to you privately.

@jblomer
Copy link
Member

jblomer commented Nov 16, 2022

The second point (rm ...external/file): that should work. Is it just failing on your local system? If so, we should investigate.

@jblomer
Copy link
Member

jblomer commented Nov 16, 2022

@cernvm-bot cloudtest

@cernvm-bot
Copy link
Collaborator

building for cloudtests finished: SUCCESS
https://lcgapp-services.cern.ch/cvmfs-jenkins/job/CvmfsFullBuildDocker/3559/

@cernvm-bot
Copy link
Collaborator

@jblomer
Copy link
Member

jblomer commented Nov 16, 2022

@HereThereBeDragons One more change needed: please add test 615 to the quick suite, otherwise it will not run as part of the standard CI tests.

@HereThereBeDragons
Copy link
Contributor Author

@jblomer added test to quick suite

running the test local, inside cern network the command below does not fail anymore

2 ) rm ${repo_dir}/external/file || return 91 line 244 with
rm: cannot remove '/cvmfs/just.test.repo/external/file': Function not implemented

@HereThereBeDragons
Copy link
Contributor Author

@cernvm-bot cloudtest

@cernvm-bot
Copy link
Collaborator

building for cloudtests finished: SUCCESS
https://lcgapp-services.cern.ch/cvmfs-jenkins/job/CvmfsFullBuildDocker/3572/

@jblomer
Copy link
Member

jblomer commented Nov 24, 2022

@cernvm-bot unittest

@jblomer
Copy link
Member

jblomer commented Nov 24, 2022

@jblomer added test to quick suite

running the test local, inside cern network the command below does not fail anymore

2 ) rm ${repo_dir}/external/file || return 91 line 244 with
rm: cannot remove '/cvmfs/just.test.repo/external/file': Function not implemented

Actually, this may be a problem of overlayfs on XFS with ftype=0 (known overlayfs issue)

@cernvm-bot
Copy link
Collaborator

@jblomer
Copy link
Member

jblomer commented Nov 25, 2022

@cernvm-bot cloudtest

@cernvm-bot
Copy link
Collaborator

building for cloudtests finished: SUCCESS
https://lcgapp-services.cern.ch/cvmfs-jenkins/job/CvmfsFullBuildDocker/3581/

@cernvm-bot
Copy link
Collaborator

@jblomer
Copy link
Member

jblomer commented Nov 25, 2022

@cernvm-bot unittest

@jblomer jblomer merged commit f160bfb into cvmfs:devel Nov 25, 2022
@HereThereBeDragons HereThereBeDragons deleted the mharvey_external_url_xattr branch December 9, 2022 14:15
@vvolkl vvolkl added this to the 2.11 milestone Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants