New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn about potential incorrect use of cvmfs_talk #3303
Conversation
Co-authored-by: Valentin Volkl <valentin.volkl@cern.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only a small but important typo
during testing i also found the following:
cvmfs_talk
> Command missing
so maybe we can add that just calling cvmfs_talk falls back to --help
? (could be another PR)
"Warning: no instance was specified. In this case, the command " | ||
"is executed for all instances defined in CVMFS_REPOSITORES but " | ||
"this list is empty. Did you mean running \n\n" | ||
" cvmfs_talk -i <repository name> <command>\n"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you also want to add the option with -p <socket>
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd rather not advertise the -p
interface. Under normal circumstances, -i
should be used.
Fixes #3075