Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict error handling of readahead #3305

Merged
merged 1 commit into from Jul 13, 2023
Merged

Restrict error handling of readahead #3305

merged 1 commit into from Jul 13, 2023

Conversation

HereThereBeDragons
Copy link
Contributor

Issue #3299

Instead of just removing kLogSyslogWarn, i think it is better to ignore errors due to not supported file type but have a hard failure if the readahead() fails due to EBADF fd is not a valid file descriptor or is not open for reading.

Man page says the on error only errnos set are either EBADF and EINVAL

@HereThereBeDragons HereThereBeDragons added this to the 2.11 milestone Jul 5, 2023
@HereThereBeDragons HereThereBeDragons self-assigned this Jul 5, 2023
@HereThereBeDragons
Copy link
Contributor Author

@cernvm-bot cloudtest

@cernvm-bot
Copy link
Collaborator

building for cloudtests finished: SUCCESS
https://lcgapp-services.cern.ch/cvmfs-jenkins/job/CvmfsFullBuildDocker/3920/

@cernvm-bot
Copy link
Collaborator

cloudtests finished: FAILURE
https://lcgapp-services.cern.ch/cvmfs-jenkins/job/CvmfsCloudTesting/1749/

@HereThereBeDragons
Copy link
Contributor Author

cannot reproduce the failure of Testing Warn on high inode watermark (Thu Jul 6 10:39:16 CEST 2023 / test number 043) in cloud test https://lcgapp-services.cern.ch/cvmfs-jenkins/job/CvmfsCloudTesting/1749/ . for me with ubunutu 22 it's successful

@HereThereBeDragons
Copy link
Contributor Author

@cernvm-bot cloudtest

@cernvm-bot
Copy link
Collaborator

building for cloudtests finished: UNSTABLE
https://lcgapp-services.cern.ch/cvmfs-jenkins/job/CvmfsFullBuildDocker/3926/

@HereThereBeDragons
Copy link
Contributor Author

@cernvm-bot cloudtest

@cernvm-bot
Copy link
Collaborator

building for cloudtests finished: SUCCESS
https://lcgapp-services.cern.ch/cvmfs-jenkins/job/CvmfsFullBuildDocker/3932/

@cernvm-bot
Copy link
Collaborator

cloudtests finished: FAILURE
https://lcgapp-services.cern.ch/cvmfs-jenkins/job/CvmfsCloudTesting/1753/

@HereThereBeDragons
Copy link
Contributor Author

@cernvm-bot cloudtest

@cernvm-bot
Copy link
Collaborator

building for cloudtests finished: SUCCESS
https://lcgapp-services.cern.ch/cvmfs-jenkins/job/CvmfsFullBuildDocker/3941/

@cernvm-bot
Copy link
Collaborator

cloudtests finished: FAILURE
https://lcgapp-services.cern.ch/cvmfs-jenkins/job/CvmfsCloudTesting/1761/

@vvolkl vvolkl force-pushed the suppress_failed_read_ahead_3299 branch from fd5b72c to 8c7a5f7 Compare July 11, 2023 12:37
@vvolkl
Copy link
Contributor

vvolkl commented Jul 11, 2023

@cernvm-bot cloudtest

@cernvm-bot
Copy link
Collaborator

building for cloudtests finished: SUCCESS
https://lcgapp-services.cern.ch/cvmfs-jenkins/job/CvmfsFullBuildDocker/3952/

@cernvm-bot
Copy link
Collaborator

cloudtests finished: FAILURE
https://lcgapp-services.cern.ch/cvmfs-jenkins/job/CvmfsCloudTesting/1774/

@HereThereBeDragons
Copy link
Contributor Author

@cernvm-bot cloudtest

@cernvm-bot
Copy link
Collaborator

building for cloudtests finished: SUCCESS
https://lcgapp-services.cern.ch/cvmfs-jenkins/job/CvmfsFullBuildDocker/3957/

@cernvm-bot
Copy link
Collaborator

cloudtests finished: SUCCESS
https://lcgapp-services.cern.ch/cvmfs-jenkins/job/CvmfsCloudTesting/1778/

@vvolkl vvolkl merged commit bf8af8f into cvmfs:devel Jul 13, 2023
5 checks passed
@HereThereBeDragons HereThereBeDragons deleted the suppress_failed_read_ahead_3299 branch July 13, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jblomer jblomer jblomer approved these changes

@vvolkl vvolkl vvolkl approved these changes

Assignees

@HereThereBeDragons HereThereBeDragons

Labels
None yet
Projects
None yet
Milestone
2.11
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@HereThereBeDragons @cernvm-bot @vvolkl @jblomer