[WIP] Uses libnettle as low-level crypto library #3576
+287
−232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When stripping existing library names from the "missing-libs" list, it's bad to have a library called go, which is then stripped from, e.g., "googlebench". Rename to golang avoids the ambiguity.
jblomer
changed the title
|
linter finished with errors: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes from OpenSSL/LibreSSL to libnettle for libcvmfs_crypto. Libnettle is taken from the system on Linux and vendored for macOS. This PR replaces hashing and symmetric crypto.
For the public-key crypto, it is likely best to still depend on OpenSSL for the I/O of (PEM-)keys and X.509 certificates. For these operations, we can take stock OpenSSL (does not require LibreSSL). The actual RSA operations can also move to nettle.
Add micro benchmarks for RipeMD160 and SHAKE-128 and HMAC-SHA256.
TODOs:
Based on #3558 (needs to be merged first for the CI to work)
Fixes #3555