Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify and reduce contextual requirements #364

Open
Tracked by #32
cvogt opened this issue Mar 3, 2017 · 0 comments
Open
Tracked by #32

unify and reduce contextual requirements #364

cvogt opened this issue Mar 3, 2017 · 0 comments
Assignees
Labels
Milestone

Comments

@cvogt
Copy link
Owner

cvogt commented Mar 3, 2017

a lot of methods / classes take a bunch of contextual arguments, most as implicits. Logger, transientCache, classLoaderCache, cbtLastModified, mavenCache, etc.

We should reduce the number of absolute arguments and whatever remains entirely implicit. Reducing can happen by either grouping things that always appear together, or by pulling the things that need them (e.g. BoundMavenDependency) deep inside outside of these functions instead and taking them as arguments instead, effectively moving the context dependencies further outside.

This standardization aims:

  • reduce the number of very frequent context arguments for more concise code
  • make all that remain implicit for more concise code
  • reduce the required ones for easier use of the functionality as libraries outside of CBT
  • reduce (or ideally remove) the coupling of a lot of functionality with CBT internal contexts
@cvogt cvogt added the feature label Mar 3, 2017
@cvogt cvogt added this to the 1.0 milestone Mar 3, 2017
@cvogt cvogt mentioned this issue Mar 3, 2017
15 tasks
@cvogt cvogt self-assigned this Mar 3, 2017
@cvogt cvogt added cleanup and removed feature labels Mar 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant