Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest Python and packages #7

Closed
andrewmackie opened this issue Oct 27, 2022 · 3 comments
Closed

Latest Python and packages #7

andrewmackie opened this issue Oct 27, 2022 · 3 comments

Comments

@andrewmackie
Copy link
Contributor

andrewmackie commented Oct 27, 2022

The current release prevents use of Python 3.10 and requires specific versions of Beautiful Soup and PyTube.

I've forked the repo to overcome these version limitations and it's working for me. I haven't made a pull request, however, as your repo doesn't have tests and I don't know whether there is a use case which would be broken by my changes.

Can you please remove these version limitations if they're not needed?

Thanks for the repo - it's effective and much easier to use than SpeechBrain.

@cvqluu
Copy link
Owner

cvqluu commented Nov 1, 2022

Hi, sorry for the delayed response. Feel free to make the pull request, if the main functionality is working (as covered by the colab notebook) then I am happy to merge those changes.

It's a good point that I should add some tests however!

@andrewmackie
Copy link
Contributor Author

Thanks and sorry for my delayed response.

I have created a new Google Colab notebook to test it in Python 3.10.

It works until calling diar.diarize_youtube() - in utls.parse_ttml(), BeautifulSoup attempts to load the lxml parser and fails to do so (in spite of the notebook installing lxml with pip and importing it in the python code). I don't have any more time to chase this down for you, sorry, because it took me a few hours to get Python 3.10 working in Google Colab (those tests would make contributing easier!).

I have created PR #8 for you to merge (or not) as you see fit.

@cvqluu
Copy link
Owner

cvqluu commented Nov 9, 2022

It's okay, the diarize_youtube functionality I plan to depracate support for, so it is not an issue.

I think this repo will be more useful for people with the general functionality working with less strict python requirements anyways. Thanks!

@cvqluu cvqluu closed this as completed Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants