Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert object struct to Object class #8

Closed
cwc opened this issue Feb 13, 2013 · 6 comments
Closed

Convert object struct to Object class #8

cwc opened this issue Feb 13, 2013 · 6 comments
Labels
Milestone

Comments

@cwc
Copy link
Owner

cwc commented Feb 13, 2013

No description provided.

@vsrz
Copy link
Contributor

vsrz commented Mar 14, 2013

might have bit off more than I can chew but I'm going to attempt this. I'll probably need your help on testing this.

@cwc
Copy link
Owner Author

cwc commented Mar 14, 2013

Yeah objects are going to be a bitch. I scanned the work you've pushed up and it looks good so far. Hopefully I'll have some time available next week.

@vsrz
Copy link
Contributor

vsrz commented Mar 14, 2013

I finished most of it last night and have a working object class with lots of refactoring done. I'll check it in when I get home. Going to do a couple of dungeon crawls when I get home today and try to cause some crashes. I'm not really sure how to test this well--do you have any better ideas?

@vsrz
Copy link
Contributor

vsrz commented Mar 15, 2013

Seems to be working okay. I was able to test various objects, cursed/blessed items, money, and activate-able, and unique items. I'm pretty busy this weekend, but this object should definitely be broken into abstract classes and virtual methods by various object types. This of course would be much harder than what I've done here.

@cwc
Copy link
Owner Author

cwc commented Mar 18, 2013

Nice, I'm going to review #15 shortly. As far as testing, there is a wizard system in there that was presumably added to make testing easier. I need to review how it works and possibly revamp it. IIRC your Unix user name has to match the hardcoded name string - not ideal.

@vsrz
Copy link
Contributor

vsrz commented Mar 18, 2013

Oh yeah, you bash the top left corner of Rampart and you can enter "Wizard" mode. That's what I generally use to test what I can. Even with Wizard mode, there are still situations where even being Omega God cannot help you with, such as this. It's feels nearly impossible to fully test something this huge. To your credit Monsters is much bigger ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants