Same patch file gathered multiple times

[Sweetchuck]

When there are two or more dependency which provide the same patch file, but with different description, then then second time the patch file cannot be applied.

Dependency 1

{
  "patches": {
    "a/a": {
      "Desc 01": "https://example.com/a.patch"
    }
  }
}

Dependency 2

{
  "patches": {
    "a/a": {
      "Desc 02": "https://example.com/a.patch"
    }
  }
}

Then the \cweagans\Composer\Patches::gatherPatches gives the following result:

{
  "a/a": {
    "Desc 01": "https://example.com/a.patch",
    "Desc 02": "https://example.com/a.patch"
  }
}

\cweagans\Composer\Util::arrayMergeRecursiveDistinct

[Sweetchuck]

This test case is also strange.
When there are two different package and they want to apply two different patches to the same (third) package, but accidentally they use the same key, then only one of the patch will be applied.

composer-patches/tests/unit/UtilTest.php

Line 70 in fac6b31

// Deep arrays with same keys

[cweagans]

I'm guessing you're using 1.x (and if you're not, you should be at this exact moment). In that case, you can use https://github.com/cweagans/composer-patches#ignoring-patches to disable one of the patches.

The test you're looking at is for 2.x. Gathering patches from dependencies is no longer supported in 2.x. I might add a command to import patches from installed dependencies, but the plugin won't do it automatically anymore.