Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of scoreboard feature #27

Closed
cwendt94 opened this issue Sep 6, 2019 · 1 comment
Closed

Get rid of scoreboard feature #27

cwendt94 opened this issue Sep 6, 2019 · 1 comment
Labels
invalid This doesn't seem right

Comments

@cwendt94
Copy link
Owner

cwendt94 commented Sep 6, 2019

No need for scoreboard feature anymore. box_scores gets all of scoreboard data plus live points update and player points update
@cwendt94 cwendt94 added the invalid This doesn't seem right label Sep 6, 2019
@cwendt94
Copy link
Owner Author

cwendt94 commented Sep 6, 2019

Looking over scoreboard feature, it should really only be used previous year data. Right now box_score can't be used before 2018 because player data is not present.

@cwendt94 cwendt94 closed this as completed Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cwendt94