-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NFL position mapping incorrect #460
Comments
These are after I updated the constant.py |
Can you provide how you are getting an incorrect position? I am not having any issues with the following.
|
yeah, definitely. I'm kind of breaking this apart to get the data I need. I used the get_league() function in the espn_requests.py file to pull the JSON data. When I do that the defaultPositionId doesn't match up. Which maybe that's the incorrect line item to be looking for. It looks like the position mapping in constant is using the eligibleSlots. I tried googling to see if ESPN had any docs on it without any luck. But the below code is an example of what George Kittle's line data looks like.
This is what I get back when I run your code for my league. It isn't incorrect it just looks weird when using the eligible slots. Why is it mapped as 'WR/TE' and not just 'TE' for most TEs? When I go to the ESPN website they just have him as a TE.
|
@BrianPaur the
So, it's not saying that the NFL has defined Freiermuth as a WR/TE. Instead, it's saying that as a TE, Freiermuth is eligible to played in the WR/TE slot. I hope this answers your question (after nearly 2 months) |
Sport
Football
Summary
I believe the position mapping for Kickers is off on the football->constant.py. I believe 5 should be 'K' not 'TE/WR'. Let me know if I'm wrong on this. My kicker kept coming back as the wrong position when pulled through. Hoping it wasn't just user error... Looks like you have 17 listed as a kicker but none of the players I have in my league come back as a 17. So I can't pinpoint what that is.
Logs/Data
No response
The text was updated successfully, but these errors were encountered: