Correctly call string.Finalize() in REVERSE function (fixes #535)

duckdb · Apr 12, 2020 · 03eafe5 · 03eafe5
1 parent 1866e91
commit 03eafe5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/function/scalar/string/reverse.cpp b/src/function/scalar/string/reverse.cpp
@@ -44,6 +44,7 @@ static void reverse_chunk_function(DataChunk &args, ExpressionState &state, Vect
 
 		auto target = StringVector::EmptyString(result, input_length);
 		strreverse(input_data, input_length, target.GetData());
+		target.Finalize();
 		return target;
 	});
 }

diff --git a/test/rigger/test_rigger.cpp b/test/rigger/test_rigger.cpp
@@ -421,4 +421,12 @@ TEST_CASE("Tests found by Rigger", "[rigger]") {
 		REQUIRE(CHECK_COLUMN(result, 0, {"0"}));
 		REQUIRE(CHECK_COLUMN(result, 1, {0}));
 	}
+	SECTION("535") {
+		REQUIRE_NO_FAIL(con.Query("CREATE TABLE t0(c0 NUMERIC);"));
+		REQUIRE_NO_FAIL(con.Query("INSERT INTO t0(c0) VALUES (-515965088);"));
+		REQUIRE_NO_FAIL(con.Query("INSERT INTO t0(c0) VALUES (1), (-5.15965088E8);"));
+		REQUIRE_NO_FAIL(con.Query("CREATE INDEX i0 ON t0(c0);"));
+		result = con.Query("SELECT t0.c0 FROM t0 GROUP BY t0.c0, REVERSE(t0.c0) ORDER BY 1;");
+		REQUIRE(CHECK_COLUMN(result, 0, {-515965088, 1}));
+	}
 }