New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot tune ffmpeg options in conversion job #413
Comments
Hi. I came across such a problem myself and fixed it this way. |
Thanks ColdRosin, I tried your suggestion and there was difference as it didn't end with error message. However, now it's stuck on "converting" and throwing error "ParseError Raw log entry:
Maybe I missed something, but just replaced what you suggested in specific file. |
Most likely, you made a mistake with the syntax. Please check the function in the file public function convertMedia() {
$threads = $this->configService->getAppConfigValue('threadLimit', 0);
$additionalConversionFlags = empty($this->additionalConversionFlags) ? '' : " {$this->additionalConversionFlags}";
$command = "ffmpeg -threads $threads -i {$this->tempSourcePath} {$additionalConversionFlags} {$this->tempOutputPath}";
$process = $this->processFactory->create($command);
$process->run();
if (!$process->isSuccessful()) {
throw new ProcessFailedException($process);
}
return $this;
} |
There was a ; missing after line (as always). After that instead of stuck, it just stops with "Has-Failures" and throws error.
This is how it looks like directly on server. I tested even replacing whole function but this didn't change plugin behaviour. Edit: Now I see it throws error and converts files - just coincidence I found that there was output. |
I also had this issue. We should really have separate fields for input options and output options, and make sure the complete command line field is not editable, as it's misleading. |
Closing, if there are other issues please create new ones 👍. Thanks for all the discussion! |
Oh great, I was about to try doing that. |
Steps to reproduce
I tried to modify command structure in last text-box where command fulfill when adding extra commands, but it didn't change anything
Expected behaviour
Media converter should execute command in this pattern:
ffmpeg -i {input} -threads 0 -c:v libx264 -movflags faststart -preset veryslow -crf 18 -pix_fmt yuv420p -c:a aac {output}
Actual behaviour
Instead, Media Converter just bundles everything before -i {input} so whole command looks like this:
ffmpeg -threads 0 -c:v libx264 -movflags faststart -preset veryslow -crf 18 -pix_fmt yuv420p -c:a aac -i {input} {output}
I'm sure that this is problem with command structure because manually this command (of course with file instead of /tmp) exits with same error.
It isn't problem with ffmpeg as it executes command from "Expected behavior" run directly on Nextcloud VM.
Workflow Media Converter app
Workflow Media Converter app version: 1.9.3
Server configuration
Operating system: Ubuntu 22.04
Web server: Apache 2.4.52
Database: Maria 10.6.16
PHP version: 8.1.2
Nextcloud Version: 28.0.1
Where did you install Nextcloud from: manually trough repositories instead of snap
Signing status:
List of activated apps:
Nextcloud configuration:
Are you using external storage, if yes which one: SMB
Are you using encryption: no
Server log (data/nextcloud.log)
The text was updated successfully, but these errors were encountered: