New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce unneeded complexity (KISS) #2

Closed

cwithmichael opened this issue Apr 20, 2022 · 1 comment

Assignees

Labels

Owner

cwithmichael commented Apr 20, 2022

Improve the code by reducing unnecessary abstractions.
This was pointed out by a user (Plecra) on Reddit

His comment:

My main recommendation would be to reduce your abstractions. The FileType trait isn't necessary - you only need a function that maps file types to headers (&'static [u8]), and another that can check them against a buffer. Other than that, there are a few nice std APIs that can help clean things up - iterator methods, ascii equality, etc.

cwithmichael added the enhancement label

Owner Author

cwithmichael commented Apr 20, 2022

The FileType trait has been removed. And the code has been improved. I'll leave this open for now though.

cwithmichael self-assigned this

cwithmichael mentioned this issue

Refactor code #6

Merged

cwithmichael closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment