Merchant Bugfixes

[alairon]

Pull request checklist

Please check if your PR fulfills the following requirements:

• Docs have been reviewed and added / updated if needed (for bug fixes / features)
• Build (npm run build) was run locally and any changes were pushed
• Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

• Merchants with any good item entries have a dangling comma in its previous rarity color
• A data collision causing existing entries in merchantAPIData to be overwritten by incoming apiData
  [Bug]: Merchants are Incorrectly Reported #15

What is the new behavior?

• Changed behavior of commas:
  • commas will show up only to separate entries where needed
  • commas will now show up as a neutral color
• Preemptively added support for large good item lists (e.g. the impossible Jeffrey where a Sian Card, Madnick Card, and Legendary Rapport items appear)
• Fixes [Bug]: Merchants are Incorrectly Reported #15
  • modified logic to prevent data from being overwritten and misreported

Does this introduce a breaking change?

• Yes
• No

The merchant data fix is largely based on my attempt to replicate the WebSocket data, where the incoming data resembles:
[{"_id":"1653078718440","region":"","server":"azena","location":"Lake Eternity","item":"Madnick Card][Legendary Rapport Item","name":"Jeffrey"}]

Other information

Image of a theoretical Jeffery with the fixes in this PR applied. Note that this was created from a simulated environment and has not appeared in the wild

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
lostarktimer	✅ Ready (Inspect)	Visit Preview	May 23, 2022 at 4:21AM (UTC)

[alairon]

Accidentally axed this branch too early