Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove secrets from repo #95

Open
jameshochadel opened this issue Feb 13, 2017 · 2 comments
Open

Remove secrets from repo #95

jameshochadel opened this issue Feb 13, 2017 · 2 comments
Assignees

Comments

@jameshochadel
Copy link
Contributor

Secrets are currently posted publicly in the repository, including database credentials and our AirBrake API key. These need to be removed, and a deployment process needs to be established in the production environment to fill them in appropriately.

@jameshochadel jameshochadel self-assigned this Feb 13, 2017
@jameshochadel
Copy link
Contributor Author

AFAIK our Postgres does not accept connections from the internet at large, so it's not currently a vulnerability, but of course the DB credentials should be removed regardless. I've changed all DB passwords on the server and will figure out a solution to automatically filling them in ASAP.

@jameshochadel
Copy link
Contributor Author

The canonical solution to this is to use environment variables on the production server. We are now doing this with the Airbrake API key.

Alternatively, Rails 5.1 has a new features called Encrypted Secrets that lets you store the secrets, encrypted, right in version control; they are edited using bin/rails secrets:edit and decrypted in appropriate environments using a separately generated key. An upgrade to this version of Rails is planned — see #101.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant