Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter dimension for the first conv1d operation #19

Open
wwang2 opened this issue Mar 28, 2021 · 0 comments
Open

Filter dimension for the first conv1d operation #19

wwang2 opened this issue Mar 28, 2021 · 0 comments

Comments

@wwang2
Copy link

wwang2 commented Mar 28, 2021

Hi! Thanks for the implementation

I think there might be some problem when implementing the conv1d layer here:

self.conv_1 = ConvSELU(i, 9, kernel_size=9)

I think the definition of o' and i' are swapped. The input filter dimension should the number of possible characters (35), and `c' should be the padded SMILES sequence length.

Just want to confirm this detail. I can submit a PR if that is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant