Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using Microsoft.Extensions.Logging.ILogger #20

Closed
HarelM opened this issue Sep 10, 2017 · 3 comments
Closed

Consider using Microsoft.Extensions.Logging.ILogger #20

HarelM opened this issue Sep 10, 2017 · 3 comments
Assignees

Comments

@HarelM
Copy link

HarelM commented Sep 10, 2017

Instead of defining an interface and implement it, consider using Microsoft's interface thus allowing clients to easily use their logger without an adapter.
Also there's a great implementation for this logger using NLog which is very powerful.

@CXuesong CXuesong self-assigned this Sep 11, 2017
@CXuesong
Copy link
Owner

Agreed. Actually I'm going to use MEL to do this. See #14.

@HarelM
Copy link
Author

HarelM commented Sep 11, 2017

My bad...

@HarelM HarelM closed this as completed Sep 11, 2017
@CXuesong
Copy link
Owner

Still, thanks for opening this issue so I can get a rough idea on how important it is to replace current ILogger interface ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants