-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integer division by zero in FSE_normalizeM2 #84
Comments
Thanks for the clear reproduction case @Makush . |
Is this still an issue? |
Yes it's still an issue. |
The issue still needs to be fixed. But I wouldn't be that concerned by it. |
@Cyan4973 First off, thank you for the very prompt responses. Given what you've said, I am happy to include this very cool work in awesome-c, as it really seems that this issue is a corner case that people wouldn't encounter casually. |
FYI, I believe that this might be fixed in the zstd code with the addition of:
I was able to repro this with another use case and I've fixed it with the addition of that if statement. Unfortunately I don't have my repro code anymore. |
@yohan1234 That code was pulled in here at ea7b345 Perhaps this is no longer an issue now. |
Hi, I get sometimes integer division by zero error from FSE_normalizeM2, when having large max symbol values. Specifically, I am using following compiler defines to compile FSE:
FSE_DEFAULT_MEMORY_USAGE=14
FSE_MAX_MEMORY_USAGE=16
FSEU16_DEFAULT_MEMORY_USAGE=14
FSEU16_MAX_MEMORY_USAGE=16
FSEU16_MAX_SYMBOL_VALUE=4095
Please find below example code that will reproduce the error.
Thanks,
Markus
The text was updated successfully, but these errors were encountered: