Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I can add blank password made of tabs #126

Closed
Tamir198 opened this issue Dec 6, 2020 · 7 comments
Closed

I can add blank password made of tabs #126

Tamir198 opened this issue Dec 6, 2020 · 7 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers
Projects

Comments

@Tamir198
Copy link
Contributor

Tamir198 commented Dec 6, 2020

Both in the login page and in the create a new user there is a requirement that the password and the email should not contain any spaces:

image

This works fine if I try to enter spaces, but I can enter a password and email that only contains tabs.
In this case, the app will act just as everything is normal and there was not a single space entered from the user.

@guyluz11 guyluz11 added this to To do low priority in Road Map Dec 6, 2020
@guyluz11
Copy link
Member

guyluz11 commented Dec 6, 2020

Interesting.
We should change the tab functionality at all.
It's should to be the next field and in the last one close the keyboard.

@guyluz11 guyluz11 added bug Something isn't working good first issue Good for newcomers labels Dec 6, 2020
@guyluz11 guyluz11 moved this from To do low priority to To do high priority in Road Map Dec 6, 2020
@Tamir198
Copy link
Contributor Author

Tamir198 commented Dec 6, 2020

Interesting.
We should change the tab functionality at all.
It's should to be the next field and in the last one close the keyboard.

I have edited my issue, this is also occurring in the email field, currently test test@test.com is count as a valid email.

@guyluz11
Copy link
Member

guyluz11 commented Feb 1, 2021

Fixed for the email field.

@Tamir198 Tamir198 closed this as completed Feb 1, 2021
Road Map automation moved this from To do high priority to Done Feb 1, 2021
@guyluz11
Copy link
Member

guyluz11 commented Feb 1, 2021

It is fixed only for the email, not for password.
So I am reopening this issue.

@guyluz11 guyluz11 reopened this Feb 1, 2021
Road Map automation moved this from Done to In progress Feb 1, 2021
@guyluz11 guyluz11 moved this from In progress to To do low priority in Road Map Feb 2, 2021
@AvielCo
Copy link
Contributor

AvielCo commented Jun 7, 2021

I will try to solve it.

@AvielCo
Copy link
Contributor

AvielCo commented Jun 9, 2021

As I said in the PR (#199), I fixed this issue; For email and password fields.

@guyluz11
Copy link
Member

guyluz11 commented Jun 9, 2021

Merged the pull request and tested it.
Thanks @Tamir198 and @AvielCo .

Will close this issue now.

@guyluz11 guyluz11 closed this as completed Jun 9, 2021
Road Map automation moved this from To do low priority to Done Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
No open projects
Development

No branches or pull requests

3 participants