Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GCP authenticator is not supported in authenticator API #2389

Closed
aloncarmel111 opened this issue Oct 14, 2021 · 1 comment
Closed

Comments

@aloncarmel111
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Cannot enable GCP authenticator using the authenticator API, the authenticator endpoint is not supporting authenticator that doesn't have service-id.

Describe the solution you would like

change the service-id to be optional parameter in the API endpoint

Additional context

The authenticator new API will update accordingly

URL:

`/:authenticator/(:service_id - optional parameter)/:account`

Example: `/authn-k8s/my-authenticator/my-company`
Example: `/authn-gcp/my-company`
  • Method:

    PATCH

  • URL Parameters:

    • :authenticator: The authenticator type (e.g. authn-k8s, authn-oidc).
    • :service_id: The name of the authenticator from the policy (!webservice <service_id>) - this is optional param.
    • :account: The Conjur account in which to enable this authenticator.
  • Request Content Type:

    application/x-www-form-urlencoded

  • Body:

    The Authenticator patch endpoint takes a single parameter, enabled, which
    may be set to either true to enable the authenticator (add it to the whitelist)
    or false to disable the authenticator (remove it from the whitelist).

@micahlee
Copy link
Contributor

Hey @aloncarmel111 , is this issue closed by #2448 or is there more work to do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants