Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credentials should be zeroized immediately after connection is made #1188

Closed
BradleyBoutcher opened this issue Apr 7, 2020 · 0 comments
Closed

Comments

@BradleyBoutcher
Copy link
Contributor

Summary

Credential zeroizing currently rests within a defer statement at internal/plugin/connectors/tcp/proxy_service.go:106. This statement will then only execute once the connection has been closed, or when a panic / error occurs early on and terminates the sequence. We should make sure that that statement is also executed immediately after the connection is made and the credentials are done being used.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Go to internal/plugin/connectors/tcp/proxy_service.go:106
  2. Set a breakpoint after line 113, for example the logger statement on line 118
  3. Verify that credentials have not been zeroized

Expected Results

When examining the value of backendCredentials after Connect has completed, if no error has occured, the value should be nil or empty.

Actual Results (including error logs, if applicable)

backendCredentials retains its value until the connection is terminated, by the process or by an error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants