WIP: Robust testing of AWS using feature-rich mock server #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahx
reviewed
Feb 8, 2021
| p, err := awssecrets.NewProvider(plugin_v1.ProviderOptions{Name: "aws"}, aws.Config{ | ||
| Endpoint: aws.String(server.URL), | ||
| }) | ||
| So(err, ShouldBeNil) |
There was a problem hiding this comment.
Since the existing test has only like two assertions, and are currently style guidelines prohibit using Convey since we decided to do all testing using Go's builtin test framework way back when, I think it would be better to switch to that rather than expand the legacy code.
There was a problem hiding this comment.
Completely agree! Thanks for flagging it I'll keep in mind to step away from Convey moving forward.
doodlesbykumbi
force-pushed
the
aws-testing
branch
from
e97f328
to
f9d0322
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What ticket does this PR close?
Resolves #1371, #510
Checklists
Change log
Test coverage
Documentation
READMEs) were updated in this PR, and/or there is a follow-on issue to update docs(For releases only) Manual tests