Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

Lost tag #151

Closed
remidhum opened this issue Aug 9, 2016 · 8 comments · Fixed by #152
Closed

Lost tag #151

remidhum opened this issue Aug 9, 2016 · 8 comments · Fixed by #152
Assignees

Comments

@remidhum
Copy link
Collaborator

remidhum commented Aug 9, 2016

Upon changing or clicking on a new section in here, the ID tag (i.e. remidhum) disappears. This causes some pages not to load up (Advertising Board in particular) and if refreshed, none of the pages load.
However, as long as the page is not refreshed, the rest of the sections will correctly open even without the name tag.

After a refresh (and a sub section change), the url is similar to this:

https://www.cyberbotics.com/doc/automobile/buildings?version=doc-automobile-objects

By adding remidhum: just after version= fixes the problem.

https://www.cyberbotics.com/doc/automobile/buildings?version=remidhum:doc-automobile-objects

@fabienrohrer
Copy link
Member

The function forging the URLs is probably not taking into account the repo name.

@fabienrohrer fabienrohrer self-assigned this Aug 9, 2016
@omichel
Copy link
Member

omichel commented Aug 9, 2016

Or the colon character : should be escaped by using %3A instead.

@fabienrohrer
Copy link
Member

The issue with advertising board seems unrelated: this link doesn't work in the omichel/master doc too: https://www.cyberbotics.com/doc/automobile/advertising-board

@fabienrohrer
Copy link
Member

.. and locally too.

I get this error in the Java console:

Failed to load resource: net::ERR_BLOCKED_BY_CLIENT

@fabienrohrer
Copy link
Member

fabienrohrer commented Aug 9, 2016

LoL AdBlock is preventing to load the page, probably because of its name :-D

@fabienrohrer
Copy link
Member

If I rename the page to ad-board.md it is working. This is probably the best to do..

@fabienrohrer
Copy link
Member

The advertising keyword should be prohibited. The file name and the file title should match. So I propose to rename this file and title to Billboard

@DavidMansolino
Copy link
Member

Well spotted the AdBlock problem 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

4 participants