Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media tags not working for FLAC files #20

Closed
basscheffers opened this issue Sep 15, 2020 · 5 comments · Fixed by #30
Closed

Media tags not working for FLAC files #20

basscheffers opened this issue Sep 15, 2020 · 5 comments · Fixed by #30
Labels
help wanted Extra attention is needed

Comments

@basscheffers
Copy link

Thanks for adding media tags support! 👍

But unfortunately, they do not seem to work for FLAC files, even though jsmediatags says it supports it.

@cybercase
Copy link
Owner

@basscheffers can't reproduce. Could you link the flac file you've tested?

@basscheffers
Copy link
Author

Mystery solved! It turns out the ripper I used (dbPowerAmp) creates tags with keys like "Title". If I open the same file in a tag editor, or a player like Audirvana, it works just fine. But (presumably) jsmediatags is case sensitive to keys and doesn't read it.

In the screenshot, the bottom file was re-saved by a tag editor, and it works. In the top file I manually changed the "Title" key to "TITLE" in the hex editor and guess what? That was enough to make it work in Web Minidisc when I chose "Title" for track name.

So yeah, sounds like jsmediatags is the most likely culprit here? If they just make theirs case insensitive, it would fix it in Web Minidisc too.

Also attached is a small FLAC with the same issue.

Thanks!
Bas.

Screen Shot 2020-09-17 at 9 10 33 pm

11 Will Smith - Keith B-Real II (Interlude).flac.zip

@cybercase
Copy link
Owner

@basscheffers Thanks for taking the time to look into this.
We could reach out to the jsmediatags maintainers by opening an issue and providing the steps to reproduce.
The fix is potentially easy, so we could also offer some help in crafting a PR.
Is this something you've time to do? Or should I take care when I'll have some free time?

@jjwbruijn
Copy link

Ref: aadsm/jsmediatags#90
Seems folks already encountered the issue. Suggested fix was to use https://github.com/Borewit/music-metadata instead of jsmediatags, not sure how much effort that would entail...

@cybercase cybercase added the help wanted Extra attention is needed label Oct 31, 2020
@Shadester
Copy link
Contributor

I will try to take a stab at it this weekend. The current lib uses onSuccess: handlers and music-metadata uses async call in the example, so some tweaking needs to be done. Also, I have no prior knowledge of node/typescript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants