Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EmlParser Header Filter Fails on MSG #61

Closed
malvidin opened this issue Mar 31, 2023 · 1 comment
Closed

EmlParser Header Filter Fails on MSG #61

malvidin opened this issue Mar 31, 2023 · 1 comment
Assignees
Labels
assess We still haven't decided if this will be worked on or not bug Something isn't working

Comments

@malvidin
Copy link

The EmlParser does not perform case insensitive filtering of email headers for submissions with the type "document/office/email".

To Reproduce
Steps to reproduce the behavior:

  1. Add "DKIM-Signature" to header_filter in the EmlParser service
  2. Submit MSG file that contains a DKIM-Signature header
  3. View EmlParser results in the submission
  4. DKIM Signature is included in the Email Headers section for the EmlParser

Expected behavior
The header_filter should be consistent across submission file types

Additional context
The msg parser does not make case-insensitive comparisons
https://github.com/CybercentreCanada/assemblyline-service-emlparser/blob/d1035125f6222255c2e7846dd3d1ef214e1947f1/emlparser/emlparser.py#L63

The eml parser makes case-insensitive comparisons:
https://github.com/CybercentreCanada/assemblyline-service-emlparser/blob/d1035125f6222255c2e7846dd3d1ef214e1947f1/emlparser/emlparser.py#L412

@malvidin malvidin added assess We still haven't decided if this will be worked on or not bug Something isn't working labels Mar 31, 2023
@gdesmar
Copy link

gdesmar commented Apr 5, 2023

Thank you for the report and sorry for the delay!
I'll go ahead and close this ticket, please feel free to reach out here or on discord if it is not working as expected!

@gdesmar gdesmar closed this as completed Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assess We still haven't decided if this will be worked on or not bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants