Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulling Latest from GitHub Is Still 1.7.8? #26

Closed
davidshq opened this issue May 14, 2017 · 4 comments · Fixed by #28
Closed

Pulling Latest from GitHub Is Still 1.7.8? #26

davidshq opened this issue May 14, 2017 · 4 comments · Fixed by #28

Comments

@davidshq
Copy link

davidshq commented May 14, 2017

Hi Folks,

Not sure what I am doing wrong, but I cannot seem to get 1.7.8.1 (that fixes the sceditor nesting) to download. I click Clone or Download --> Download Zip. I delete the old cosmo directory and replace it with the cosmo directory in the downloaded zip.

When I go back to the forums and edit a nested post, it shows the nesting in the WYSIWYG, but then doesn't parse the code when I view it, for example see:

http://ccbusergroup.com/viewtopic.php?f=4&t=534&p=726#p726

I made a new post and it seems to do half and half - some it processes, some it doesn't:
http://ccbusergroup.com/viewtopic.php?f=15&t=551

Also, in the ACP Extensions Manager it still shows that I am using 1.7.8 not 1.7.8.1 even though I've replaced the file.

Any help is appreciated!

Thanks,
Dave

@Nitair
Copy link
Collaborator

Nitair commented Jun 16, 2017

I will make a PR with fixed version.

@cYbercOsmOnauT
Copy link
Owner

Ah great. Thanks! I have two kids and two jobs and a single father. So my free time is very small atm. :)

@Nitair
Copy link
Collaborator

Nitair commented Jun 22, 2017

Yeah no problem. Maybe I can help you out a bit since I'm using phpbb3.2 as my test enviroment. I'm usally a C++ programmer, but shouldn't be a big deal.

@cYbercOsmOnauT
Copy link
Owner

Yes sure.

Nitair pushed a commit that referenced this issue Jun 22, 2017
[Update 1.7.9] Several fixes
## Summary
* Better formating code
* Use youtube bbcode w/o any issues (closes #24)
* Version should be displayed probably (closes #26)
* Fixes Travis CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants