Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing to set jupyterhubHost variable when Javascript is not supported (for e.g JupyterLab) #27

Closed
mitkotak opened this issue Jun 27, 2022 · 3 comments
Closed

Failing to set jupyterhubHost variable when Javascript is not supported (for e.g JupyterLab) #27

mitkotak opened this issue Jun 27, 2022 · 3 comments

Comments

@mitkotak
Copy link
Collaborator

mitkotak commented Jun 27, 2022 •
edited

Issue

SDK is not able to find JUPYTER_INSTANCE_URL in JupyterLab environments and even if it can, it does not support Javascript to capture the variable as done here

Solution

Allow the user to specify jupyterhost ip and port and migrate to service url instead of jupyter instance url

RoadMap

if enable_jupyter raises some kind of javascript exception then prompt the user to enter the url and port similar to login
@mitkotak mitkotak changed the title Failing to set `jupyterhubHost variable when Javascript is not supported (for e.g JupiterLab) Failing to set jupyterhubHost variable when Javascript is not supported (for e.g JupiterLab) Jun 27, 2022
@mitkotak mitkotak changed the title Failing to set jupyterhubHost variable when Javascript is not supported (for e.g JupiterLab) Failing to set jupyterhubHost variable when Javascript is not supported (for e.g JupyterLab) or if JUPYTER_INSTANCE_URL is not present Jun 27, 2022
@mitkotak mitkotak changed the title Failing to set jupyterhubHost variable when Javascript is not supported (for e.g JupyterLab) or if JUPYTER_INSTANCE_URL is not present Failing to set jupyterhubHost variable when Javascript is not supported (for e.g JupyterLab) Jun 27, 2022
@mitkotak
Copy link
Collaborator Author

@zimo-xiao @alexandermichels Let me know if this makes sense. Thanks !

@mitkotak mitkotak mentioned this issue Jul 7, 2022
Merged
@alexandermichels
Copy link
Member

@mitkotak Did this ever get resolved? It seems that #34 addresses it, but I wanted to verify before closing.

@mitkotak
Copy link
Collaborator Author

Yup it's resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexandermichels @mitkotak